Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added table record mock mode with companies #2715

Merged
merged 3 commits into from
Nov 25, 2023
Merged

Added table record mock mode with companies #2715

merged 3 commits into from
Nov 25, 2023

Conversation

lucasbordeau
Copy link
Contributor

@lucasbordeau lucasbordeau commented Nov 25, 2023 •
edited by charlesBochet
Loading

  • Added companies mocks from demo data
image

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 25, 2023 •
edited
Loading

Fails
🚫

Danger failed to run dangerfile.ts.

Error SyntaxError

Cannot use import statement outside a module
dangerfile.ts:2
import todos from "danger-plugin-todos";
^^^^^^

SyntaxError: Cannot use import statement outside a module
    at internalCompileFunction (node:internal/vm:73:18)
    at wrapSafe (node:internal/modules/cjs/loader:1178:20)
    at Module._compile (node:internal/modules/cjs/loader:1220:27)
    at requireFromString (/home/runner/work/twenty/twenty/packages/twenty-utils/node_modules/require-from-string/index.js:28:4)
    at /home/runner/work/twenty/twenty/packages/twenty-utils/node_modules/danger/distribution/runner/runners/inline.js:161:68
    at step (/home/runner/work/twenty/twenty/packages/twenty-utils/node_modules/danger/distribution/runner/runners/inline.js:52:23)
    at Object.next (/home/runner/work/twenty/twenty/packages/twenty-utils/node_modules/danger/distribution/runner/runners/inline.js:33:53)
    at /home/runner/work/twenty/twenty/packages/twenty-utils/node_modules/danger/distribution/runner/runners/inline.js:27:71
    at new Promise (<anonymous>)
    at __awaiter (/home/runner/work/twenty/twenty/packages/twenty-utils/node_modules/danger/distribution/runner/runners/inline.js:23:12)

Dangerfile

--------------------^

Generated by 🚫 dangerJS against 9106337

charlesBochet
charlesBochet reviewed Nov 25, 2023
View reviewed changes
Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments!

front/src/modules/object-record/components/RecordTableMockModeEffect.tsx Outdated
return <></>;
};

const mock = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should extract that to another file!

front/src/modules/object-record/components/RecordTableContainerMockMode.tsx Outdated

const { persistViewFields } = useViewFields(viewScopeId);

const { setTableFilters, setTableSorts, setTableColumns } = useRecordTable({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable

front/src/modules/object-record/components/RecordTableContainerMockMode.tsx Outdated
@@ -0,0 +1,79 @@
import styled from '@emotion/styled';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel we should not re-add this to object-record folder and create a separated company-record-table-mock module

@charlesBochet charlesBochet merged commit f0e20b0 into main Nov 25, 2023
4 of 8 checks passed
@charlesBochet charlesBochet deleted the feat/add-record-table-mock-mode branch November 25, 2023 18:50
@charlesBochet charlesBochet mentioned this pull request Nov 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesBochet charlesBochet charlesBochet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasbordeau @charlesBochet