feat: add active and disabled object tables to settings #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lucasbordeau
reviewed
Oct 5, 2023
charlesBochet
approved these changes
Oct 5, 2023
| return ( | ||
| <StyledTableCell | ||
| className={className} | ||
| isNumberCell={ |
There was a problem hiding this comment.
I feel that isNumberCell should be a prop of the Cell and decided by the caller. We might want to display numbers aligned to the left if they are string.
What if in the same column we have strings containing a mix of numeric and non numeric values:
sldkfj
1
2
sdflk
not a big challenge though, I'm fine with the current implementation, we can see later once we use it
There was a problem hiding this comment.
maybe an alignment = 'right' | 'left' as a prop
lucasbordeau
approved these changes
Oct 5, 2023
charlesBochet
deleted the
feat/add-active-and-disabled-objects-tables-to-settings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1799, Closes #1800