Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Overview page & edited Getting Started page #1875

Merged
merged 8 commits into from
Oct 7, 2023

Conversation

nimraahmed
Copy link
Contributor

@FelixMalfait Added Overview page & edited Getting Started page to the documentation

@CLAassistant
Copy link

CLAassistant commented Oct 5, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@FelixMalfait FelixMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!

sidebar_custom_props:
icon: TbBolt
icon: TbDeviceDesktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't TbDeviceDesktop already used elsewhere? I didn't check but assume it would be for local setup. Make sure it isn't used twice, that would be ugly :)


If you are looking to install the project locally, either to try it or to contribute, check out our [developer guide](/developer/local-setup).
## Prerequisites
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you copy/paste the content from another page? We'd like to avoid duplicate content from one page to another.
Maybe you planned to remove it after? We try not to merge PR in an intermediate state. If you raise a PR it's better if it doesn't break anything or introduce any bad pattern

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use yarn exclusively and don't introduce this file


Twenty is a modern CRM offering the flexibility of open source, advanced features, and a sleek design that puts teams in full control.

Twenty's codebase is adaptable, fostering a collaborative environment where every user can contribute. This extensible and modular design ensures our product evolves with you, cultivating mutually beneficial growth that promotes progress and innovation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry I know we wrote all of this text in README (probably I committed it), but I really don't like it anymore haha.
I'll send you things we can take inspiration from in Discord

@nimraahmed
Copy link
Contributor Author

nimraahmed commented Oct 7, 2023

@FelixMalfait
Changes made in recent commits:

  • Added an overview page with more details about the product
  • Fixed edit link in the docs
  • Moved self-hosting above developer guide in the docs
  • Moved glossary to additional resources in the docs
  • Revised project readme
  • Cleaned up and edited local setup page in the docs to make steps clearer & more structured
  • Deleted sweep.yaml, and .ergomake and .devcontainer folders
  • Added contributing.md, moved security.md to .github

Copy link
Member

@FelixMalfait FelixMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@@ -7,11 +7,12 @@
</p>

<h2 align="center" >A Modern Open Source CRM </h3>
<p align="center">Crafted with Precision. Built for Success.</p>
<p align="center">CRM flexibility, tailored to your unique business needs</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not a huge fan but it's already an improvement so we can merge it this way!

README.md Outdated
@@ -21,31 +22,37 @@
</picture>
</a>
</p>
<br>

We’ve spent thousands of hours grappling with traditional CRMs/platforms like HubSpot, Pipedrive and Salesforce to align them with our business needs, only to end up frustrated—customizations are complex and the closed ecosystems of these platforms can feel restrictive.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change "Hubspot, Pipedrive and Salesforce" to "Salesforce or Pipedrive"

README.md Outdated
<picture>
<source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/twentyhq/twenty/main/docs/static/img/create-tasks-dark.png">
<source media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/twentyhq/twenty/main/docs/static/img/create-tasks-light.png">
<img src="./docs/static/img/preview-light.png" alt="Companies view" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we messed up initially. What is this tag with a different image?

@@ -80,6 +87,15 @@ Below are the features we have implemented to date.
</picture>
</p>

<p align="center">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No title? For consistency. Design might be a bit odd otherwise no?

README.md Outdated
<img alt="Book us with Cal.com" src="https://cal.com/book-with-cal-light.svg" height="40">
</picture>
</a>
Welcome to the future of CRM. Welcome to Twenty.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'd get rid of this as it's not necessary and a bit too much marketing speak

README.md Outdated
# Office hours
Want to meet the team? Get direct support?
Feel free to book a slot during our office hours.
🚀 Get Started with [Twenty](https://docs.twenty.com/developer/local-setup).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link on full CTA (including get started...)?

@@ -1,4 +1,4 @@
{
"label": "Developer guide",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename it? Maybe you've planned it for future steps with other changes we have discussed. But we need to clarify contributing VS extending the CRM which isn't the same

README.md Show resolved Hide resolved
@FelixMalfait FelixMalfait merged commit 7b6ee4e into twentyhq:main Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants