Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Menus go back button style fix #1860

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

alfredlouisw8
Copy link
Contributor

fixes #1582

image

@lucasbordeau
Copy link
Contributor

Nice, we should keep the same icon size but have the icon button take more space :

Current :

image

Desired :

image

@alfredlouisw8
Copy link
Contributor Author

I've updated the PR. Kindly check again @lucasbordeau :)

@charlesBochet
Copy link
Member

@alfredlouisw8
I have taken another look and I think we should use the LightIconButton component to display the icon actually.
If you go to figma, you can click on component and identify which component should be used:
https://www.figma.com/file/xt8O9mFeLl46C5InWwoMrN/Twenty?type=design&node-id=6377-158599&mode=design&t=Bks836akwMMnwvOf-4

image

(you can see LightIconButton in the right panel on figma)

Could you try to use this LightIconButton (size small, variant tertiary) to display the arrow and remove the StyledStartIconWrapper (except maybe we need it to apply a margin/padding

@alfredlouisw8
Copy link
Contributor Author

sure! I've updated the PR :) @lucasbordeau @charlesBochet

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you!

@charlesBochet charlesBochet merged commit 73fa968 into twentyhq:main Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menus "go back" button style fix
3 participants