feat: add board options dropdown and pipeline stage creation #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi 👋 Here's a preview environment 🚀 https://front-twentyhq-twenty-1399.env.ergomake.link Environment Summary 📑
Here are your environment's logs. For questions or comments, join Discord. Click here to disable Ergomake. |
lucasbordeau
reviewed
Sep 1, 2023
|
|
||
| const [boardColumns, setBoardColumns] = useRecoilState(boardColumnsState); | ||
|
|
||
| const resetMenu = useCallback(() => { |
There was a problem hiding this comment.
Could we keep useCallback for compute intensive functions ? Wrapping every function in a useCallback is making the code less readable than it optimizes the compute, see this excellent article for reference : https://kentcdodds.com/blog/usememo-and-usecallback
- remove useCallback
thaisguigon
force-pushed
the
feat/add-pipeline-stage-from-board-options-dropdown
branch
from
bb9a506 to
5a0abec
Compare
lucasbordeau
approved these changes
Sep 4, 2023
lucasbordeau
deleted the
feat/add-pipeline-stage-from-board-options-dropdown
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1395