Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unselect all cards using esc key or click #1393

Merged
merged 7 commits into from
Sep 1, 2023
Merged

unselect all cards using esc key or click #1393

merged 7 commits into from
Sep 1, 2023

Conversation

friendlymatthew
Copy link
Contributor

@friendlymatthew friendlymatthew commented Aug 30, 2023 •
edited
Loading

Ticket: #1264

Working Demo:
https://github.com/twentyhq/twenty/assets/38759997/de34769c-1bf5-40d4-9bc1-cc5c5d6c83e0

Explanation:
A boardEntityCard gets selected in two ways, you can click on the card or drag select with your cursor.

Card clicking selection logic is stored in useCurrentCardSelected
Drag select selection logic is stored in useSetCardSelected

unselectAllActiveCards is a callback that resets activeCardIds and actionBarOpenState to false.

@ergomake
Copy link

ergomake bot commented Aug 30, 2023 •
edited
Loading

Hi 👋

Here's a preview environment 🚀

https://front-twentyhq-twenty-1393.env.ergomake.link

Environment Summary 📑

Container Source URL
front Dockerfile https://front-twentyhq-twenty-1393.env.ergomake.link
server Dockerfile https://server-twentyhq-twenty-1393.env.ergomake.link
postgres Dockerfile [not exposed - internal service]

Here are your environment's logs.

For questions or comments, join Discord.

Click here to disable Ergomake.

@lucasbordeau lucasbordeau merged commit c3c5cb4 into twentyhq:main Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasbordeau lucasbordeau lucasbordeau approved these changes

Assignees
No one assigned
Labels
-PR: awaiting author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@friendlymatthew @lucasbordeau