Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix person deletion not reflected on Opportunities POC #1387

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Fix person deletion not reflected on Opportunities POC #1387

merged 2 commits into from
Aug 31, 2023

Conversation

charlesBochet
Copy link
Member

@charlesBochet charlesBochet commented Aug 30, 2023 •
edited
Loading

Fixing data optimistic update.

There are different cases:

  1. An entity is deleted. This entity should be deleted from apollo cache through cache.evict:
update: (cache) => {
  companyIdsToDelete.forEach((companyId) => {
    cache.evict({
      id: cache.identify({ __typename: 'Company', id: companyId }),
    });
    cache.gc();
  });
},

@ergomake
Copy link

ergomake bot commented Aug 30, 2023 •
edited
Loading

Hi 👋

Here's a preview environment 🚀

https://front-twentyhq-twenty-1387.env.ergomake.link

Environment Summary 📑

Container Source URL
front Dockerfile https://front-twentyhq-twenty-1387.env.ergomake.link
server Dockerfile https://server-twentyhq-twenty-1387.env.ergomake.link
postgres Dockerfile [not exposed - internal service]

Here are your environment's logs.

For questions or comments, join Discord.

Click here to disable Ergomake.

@charlesBochet charlesBochet merged commit 2d5cb9c into main Aug 31, 2023
@charlesBochet charlesBochet deleted the 1339-timebox-optimistic-rendering branch August 31, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasbordeau lucasbordeau lucasbordeau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlesBochet @lucasbordeau