Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: create/update/delete one view instead of many #1384

Merged
merged 1 commit into from
Aug 30, 2023
Merged

refactor: create/update/delete one view instead of many #1384

merged 1 commit into from
Aug 30, 2023

Conversation

thaisguigon
Copy link
Contributor

Closes #1359

@thaisguigon thaisguigon marked this pull request as ready for review August 30, 2023 09:48
@thaisguigon thaisguigon force-pushed the refactor/update-one-view-at-a-time branch from deca16b to e04f0e8 Compare August 30, 2023 09:56
@ergomake
Copy link

ergomake bot commented Aug 30, 2023

Hi 👋

Here's a preview environment 🚀

https://front-twentyhq-twenty-1384.env.ergomake.link

Environment Summary 📑

Container Source URL
front Dockerfile https://front-twentyhq-twenty-1384.env.ergomake.link
server Dockerfile https://server-twentyhq-twenty-1384.env.ergomake.link
postgres Dockerfile [not exposed - internal service]

Here are your environment's logs.

For questions or comments, join Discord.

Click here to disable Ergomake.

charlesBochet
charlesBochet approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thaisguigon thaisguigon merged commit 6eadd1d into main Aug 30, 2023
@thaisguigon thaisguigon deleted the refactor/update-one-view-at-a-time branch August 30, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesBochet charlesBochet charlesBochet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor useViews hook to create/update/delete one view instead of many
2 participants
@thaisguigon @charlesBochet