New page structure #1377
Merged
New page structure #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi 👋 We couldn't create a preview environment for this pull-request 😥 You can see your environment build logs here. Please double-check your If you need help, email us at contact@getergomake.com or join Discord. Click here to disable Ergomake. |
| import { IconPlus } from '@/ui/icon'; | ||
|
|
||
| type OwnProps = { | ||
| handleClick: () => void; |
There was a problem hiding this comment.
The convention is to use onClick for event in props
|
|
||
| type OwnProps = { | ||
| isFavorite: boolean; | ||
| handleClick: () => void; |
|
Nice PR I think it's ok, we'll refactor more if we see missing pages. |
|
Sure fixed - coming from other frameworks where this might break but here its fine :) |
lucasbordeau
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did I miss something ?
closes #1333