feat: add page titles using React Helmet #1321
Conversation
|
Hi 👋 Here's a preview environment 🚀 https://front-twentyhq-twenty-1321.env.ergomake.link Environment Summary 📑
Here are your environment's logs. For questions or comments, join Discord. Click here to disable Ergomake. |
|
Looks great @mustajab-ikram! I think you need to fix the tests (I suspect, you need to also add the HelmetProvider to our Pages Decorators?) To run them: and in another terminal Once they are green, we can merge! |
front/src/utils/title-utils.ts
Outdated
| case AppPath.OpportunitiesPage: | ||
| return 'Opportunities'; | ||
| case `${AppBasePath.Settings}/${SettingsPath.ProfilePage}`: | ||
| return 'Profile Settings'; |
front/src/utils/title-utils.ts
Outdated
| case `${AppBasePath.Settings}/${SettingsPath.WorkspaceMembersPage}`: | ||
| return 'Workspace Members Settings'; | ||
| case `${AppBasePath.Settings}/${SettingsPath.Workspace}`: | ||
| return 'Workspace Settings'; |
front/src/utils/title-utils.ts
Outdated
| case `${AppBasePath.Settings}/${SettingsPath.Experience}`: | ||
| return 'Experience'; | ||
| case `${AppBasePath.Settings}/${SettingsPath.WorkspaceMembersPage}`: | ||
| return 'Workspace Members Settings'; |
| </ShowPageLeftContainer> | ||
| <ShowPageRightContainer | ||
| <> | ||
| <Helmet> |
There was a problem hiding this comment.
Maybe extract this to a PageTitle component under @/ui/utilities/page-title
There was a problem hiding this comment.
created a separate component for this
mustajab-ikram
force-pushed
the
feature/show-page-titles
branch
from
7cd0942 to
f0ea902
Compare
|
@mustajab-ikram Looks good, we still need to fix those tests :) |
done |
I have completed the task related to Issue #1294. I have added the Page Title functionality using React Helmet Async lib.
Please take a look at the PR when you get a chance @charlesBochet. Let me know if there are any further changes or improvements you would like to see.
closes #1294