Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect newlines in data declarations in more cases #1096

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Respect newlines in data declarations in more cases #1096

merged 1 commit into from
Feb 8, 2024

Conversation

mrkkrp
Copy link
Member

@mrkkrp mrkkrp commented Feb 5, 2024

Close #1077, close #947.

@mrkkrp mrkkrp requested a review from amesgen February 5, 2024 16:13
@mrkkrp mrkkrp force-pushed the respect-more-newlines-in-data-declartions branch 2 times, most recently from ec9f6c4 to 7527316 Compare February 5, 2024 18:57
@mrkkrp mrkkrp marked this pull request as draft February 5, 2024 20:10
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024 •
edited
Loading

🚀 Deployed on https://9ab6b2d01eeed42b30544cc66f622c156fd11264--ormolu-live.netlify.app

@github-actions github-actions bot temporarily deployed to pull request February 6, 2024 10:59 Inactive
@mrkkrp mrkkrp force-pushed the respect-more-newlines-in-data-declartions branch from bd9342b to 0c92cc7 Compare February 6, 2024 11:23
@mrkkrp mrkkrp marked this pull request as ready for review February 6, 2024 11:23
@github-actions github-actions bot temporarily deployed to pull request February 6, 2024 12:47 Inactive
amesgen
amesgen reviewed Feb 8, 2024
View reviewed changes
Copy link
Member

@amesgen amesgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, just one question about non-compact single constructor ADTs.

data/examples/declaration/data/field-layout/record-1-out.hs Show resolved Hide resolved
src/Ormolu/Printer/Meat/Declaration/Data.hs Outdated Show resolved Hide resolved
@mrkkrp mrkkrp force-pushed the respect-more-newlines-in-data-declartions branch from 0c92cc7 to 9ab6b2d Compare February 8, 2024 11:56
@github-actions github-actions bot temporarily deployed to pull request February 8, 2024 12:08 Inactive
@mrkkrp mrkkrp merged commit 4667377 into master Feb 8, 2024
10 checks passed
@mrkkrp mrkkrp deleted the respect-more-newlines-in-data-declartions branch February 8, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amesgen amesgen amesgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Format existential data types better Line breaks ignored in data type declarations.
2 participants
@mrkkrp @amesgen