Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecesary newline with bidirectional pattern synonyms #843

Closed
amesgen opened this issue Dec 8, 2021 · 0 comments · Fixed by #851
Closed

Unnecesary newline with bidirectional pattern synonyms #843

amesgen opened this issue Dec 8, 2021 · 0 comments · Fixed by #851
Labels
style Nitpicking and things related to purely visual aspect for formatting.
Milestone
0.5.0.0

Comments

@amesgen
Copy link
Member

amesgen commented Dec 8, 2021

With 0.4.0.0, the snippet

{-# LANGUAGE PatternSynonyms #-}

pattern Seq l l' <- Seq' l l'
  where
    Seq l l' = case l' of
      Empty -> l
      _ -> Seq' l l'

is formatted to

{-# LANGUAGE PatternSynonyms #-}

pattern Seq l l' <-
  Seq' l l'
  where
    Seq l l' = case l' of
      Empty -> l
      _ -> Seq' l l'

where the newline after the <- seems a bit unnecessary (but it probably should be present if the pattern were mult-line).
@amesgen amesgen added the style Nitpicking and things related to purely visual aspect for formatting. label Dec 8, 2021
@mrkkrp mrkkrp added this to the 0.5.0.0 milestone Dec 15, 2021
@mrkkrp mrkkrp mentioned this issue Dec 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
style Nitpicking and things related to purely visual aspect for formatting.
Projects
None yet
Milestone
0.5.0.0
Development

Successfully merging a pull request may close this issue.

Format bidirectional pattern synonyms nicer tweag/ormolu
2 participants
@mrkkrp @amesgen