Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format existential data types better #1077

Closed
brandonchinn178 opened this issue Nov 17, 2023 · 1 comment · Fixed by #1096
Closed

Format existential data types better #1077

brandonchinn178 opened this issue Nov 17, 2023 · 1 comment · Fixed by #1096
Labels
style Nitpicking and things related to purely visual aspect for formatting.
Milestone
0.7.4.0

Comments

@brandonchinn178
Copy link
Collaborator

I think this should be the correct formatting:

data IndexWithInfo schema =
  forall x.
  IndexWithInfo
    { checkedIndex :: Index schema x
    , checkedIndexName :: U.Variable
    , checkedIndexType :: Type x
    }

Currently, Ormolu reformats this to

data IndexWithInfo schema = forall x.
  IndexWithInfo
  { checkedIndex :: Index schema x
  , checkedIndexName :: U.Variable
  , checkedIndexType :: Type x
  }
@amesgen amesgen added the style Nitpicking and things related to purely visual aspect for formatting. label Nov 20, 2023
@amesgen
Copy link
Member

amesgen commented Nov 20, 2023

Yeah, I think we could respect few more linebreaks here, also see #947.

@mrkkrp mrkkrp added this to the 0.7.4.0 milestone Jan 19, 2024
@mrkkrp mrkkrp mentioned this issue Feb 5, 2024
Merged
@BrewTestBot BrewTestBot mentioned this issue Feb 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
style Nitpicking and things related to purely visual aspect for formatting.
Projects
None yet
Milestone
0.7.4.0
Development

Successfully merging a pull request may close this issue.

Respect newlines in data declarations in more cases tweag/ormolu
3 participants
@brandonchinn178 @mrkkrp @amesgen