Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update stylelint and stylelint-config-standard #137

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Update stylelint and stylelint-config-standard #137

merged 1 commit into from
Apr 19, 2022

Conversation

XhmikosR
Copy link
Member

@ffoodd better discuss the issue with currentColor here :)

So, the question is if our supported browsers support this. Keep in mind we use the same config in v4-dev too.

@XhmikosR
Copy link
Member Author

Friendly ping @ffoodd :)

@XhmikosR XhmikosR mentioned this pull request Jan 30, 2022
Merged
@ffoodd
Copy link
Member

ffoodd commented Feb 2, 2022 •
edited
Loading

Sorry for the delay: could you please remind me the issue with currentColor?

By reading Stylelint's changelog, I guess it concerns our inlined SVGs: if so, I suggest we move to lowercase as recommended by Stylelint (based on recent spec changes, however both cases are already supported AFAIC.

We could set the new camelCaseSvgKeywords setting to true to avoid changing our sources, but that doesn't feel right to me.

@XhmikosR XhmikosR changed the title Update stylelint to v14.3.0 Update stylelint and stylelint-config-standard Mar 1, 2022
@XhmikosR
Copy link
Member Author

XhmikosR commented Mar 1, 2022

@ffoodd @mdo what I don't know is if all of our supported browsers support the lowercase currentvalue keyword. For v5, we should be fine, but for v4 I'm not sure...

Let me know how to proceed :)

@XhmikosR XhmikosR marked this pull request as ready for review March 1, 2022 13:05
@XhmikosR XhmikosR requested review from ffoodd and mdo March 1, 2022 13:05
@ffoodd
Copy link
Member

ffoodd commented Mar 2, 2022 •
edited
Loading

Just ran a simple test using BrowserStack, both values work fine in IE10 and 11. In fact it seems like IE10 transforms the value (but it's using Firebug to inspect, might be the tool, too).

AFAIK this shouldn't be an issue, since CSS values are supposed to be case insensitive for the most parts. currentColor comes from SVG but I suspect the case never really mattered in CSS. Don't know what or how to test this further though, I didn't find any literature on the topic…

So my two cents: let's go for it.

@XhmikosR XhmikosR force-pushed the dev branch 4 times, most recently from 28561ef to c451e45 Compare March 17, 2022 07:45
@XhmikosR
Update dependencies
4c3e9da 
* stylelint-config-standard  ^24.0.0  →  ^25.0.0
* stylelint-scss              ^4.1.0  →   ^4.2.0
* eslint                     ^8.10.0  →  ^8.13.0
* stylelint                  ^14.2.0  →  ^14.7.1
@XhmikosR XhmikosR merged commit 871b22b into main Apr 19, 2022
@XhmikosR XhmikosR deleted the dev branch April 19, 2022 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffoodd ffoodd Awaiting requested review from ffoodd

@mdo mdo Awaiting requested review from mdo

Assignees
No one assigned
Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XhmikosR @ffoodd