Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CSSLint and CSSComb support. #431

Merged
merged 6 commits into from
Mar 7, 2014
Merged

Add CSSLint and CSSComb support. #431

merged 6 commits into from
Mar 7, 2014

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Mar 5, 2014

Fixes #281.

/CC @cvrebert @connor @connors @mdo

Note that I left the csslint target out of tests on purpose since it fails due to #390. When that issue is fixed, we should add it in tests.

@XhmikosR XhmikosR added this to the 2.0.2 milestone Mar 5, 2014
@XhmikosR XhmikosR self-assigned this Mar 5, 2014
@mdo
Copy link
Member

mdo commented Mar 5, 2014

I'm guessing by all the reordering that we have some property order changes to make to the source Sass files?

Also, is there a way in CSScomb (I haven't checked yet) to remove the spaces between values in the rgba() colors?

@XhmikosR
Copy link
Member Author

XhmikosR commented Mar 5, 2014

We could change some stuff around in Sass files indeed.

For rgba() I can't find any info how to remove the spaces so far.

@XhmikosR
Copy link
Member Author

XhmikosR commented Mar 7, 2014

/CC @connors: maybe you are up to changing the properties order in the Sass files after this is in 👼

@connors
Copy link
Collaborator

connors commented Mar 7, 2014

you know it. ❤️

@connors
Copy link
Collaborator

connors commented Mar 7, 2014

@XhmikosR Would you rather me go in and work on fixing the property order in this pull request? Or do you just wanna get this in and I get follow up?

@XhmikosR
Copy link
Member Author

XhmikosR commented Mar 7, 2014

I think it will be better if we merged this separately. Did you review the rest of the changes? If you agree I'll merge this and you can work on the rest.

@connors
Copy link
Collaborator

connors commented Mar 7, 2014

👍

XhmikosR added a commit that referenced this pull request Mar 7, 2014
@XhmikosR
Merge pull request #431 from twbs/csslint
7db2da9 
Add CSSLint and CSSComb support.
@XhmikosR XhmikosR merged commit 7db2da9 into master Mar 7, 2014
@XhmikosR XhmikosR deleted the csslint branch March 7, 2014 05:59
@connors connors mentioned this pull request Mar 12, 2014
Closed
@connors connors mentioned this pull request Apr 1, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@XhmikosR XhmikosR

Labels
css docs grunt
Projects
None yet
Milestone
2.0.2
Development

Successfully merging this pull request may close these issues.

add CSSLint and/or CSScomb tasks to Gruntfile?
3 participants
@XhmikosR @mdo @connors