Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #5362 #5366

Merged
merged 2 commits into from
Oct 18, 2012
Merged

Fix for #5362 #5366

merged 2 commits into from
Oct 18, 2012

Conversation

Sinetheta
Copy link
Contributor

Fix for issue 5362 tab events fired on wrong dropdown anchor.

Fix for issue [5362](#5362):
tab events fired on wrong dropdown anchor.
@koenpunt
Copy link
Contributor

koenpunt commented Oct 8, 2012

Hey @Sinetheta,

Thanks for opening this pull-request! Unfortunately, it looks like it fails to pass the criteria neccessary for submitting to bootstrap. The following things are currently failing:

  • should always include a unit test if changing js files

For a full list of issue filing guidelines, please refer to the bootstrap issue filing guidelines.

thanks!

@Sinetheta
Copy link
Contributor Author

I have added two tests which fail under the old codebase but pass after the change. Sorry it took forever for me to figure out how to add another commit to a pull request. Please let me know if there are any other issues.

@koenpunt
Copy link
Contributor

koenpunt commented Oct 9, 2012

Ow crap, my bad, did run make haunt to see what it does and at first it showed me nothing, but now I see; it commented on all the issues.. But anyway, if it assures people to follow the guidelines maybe it aint that bad :)

@Sinetheta
Copy link
Contributor Author

@koenpunt I'm sorry, but that was Greek to me ;)

I'm brand new to github and am still trying to learn the proper procedure for contributing to the projects I love, like bootstrap. Is there anything I still need to change for this pull request to work correctly?

Thanks for having a look at this issue.

@fat
Copy link
Member

fat commented Oct 18, 2012

this is awesome, thanks @Sinetheta

fat added a commit that referenced this pull request Oct 18, 2012
@fat fat merged commit 24b5e6c into twbs:2.1.2-wip Oct 18, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants