Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Drop the $small-font-size variable for the newer $font-size-sm one" #20918

Merged
merged 1 commit into from
Oct 17, 2016
Merged

Revert "Drop the $small-font-size variable for the newer $font-size-sm one" #20918

merged 1 commit into from
Oct 17, 2016

Conversation

mdo
Copy link
Member

@mdo mdo commented Oct 17, 2016

Reverts #20867

@mdo mdo added this to the v4.0.0-alpha.5 milestone Oct 17, 2016
@mdo
Copy link
Member Author

mdo commented Oct 17, 2016

We actually do want to keep the difference between these two variables; one is a relative percentage size for use in all typography and the other is a specific font-size as part of a type scale.

@mdo mdo merged commit 5b7ec49 into v4-dev Oct 17, 2016
@mdo mdo deleted the revert-20867-dedupe-sm-vars branch October 17, 2016 02:42
@mdo mdo mentioned this pull request Oct 17, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
css v4
Projects
None yet
Milestone
v4.0.0-alpha.5
Development

Successfully merging this pull request may close these issues.
1 participant
@mdo