Show clearfix for examples for xs/sm devices #19287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `hidden-sm-up` to `hidden-md-up` as the clearfix divs should be visible on both `xs` and `sm` devices (widths of 6 columns).
|
(The Travis CI failure is irrelevant and can be safely ignored.) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the divs on the Examples page in v4 don't clear correctly on
smsized screens (eg the Carousel example at http://v4-alpha.getbootstrap.com/examples/#custom-components). The reason for this is the example divs are 6 columns wide onxsandsmdevices via.col-xs-6, but the.clearfixafter every two examples uses.hidden-sm-up. This results in the.clearfixbeing hidden onsmdevices, where it is needed.This PR changes
hidden-sm-uptohidden-md-up, ensuring the clearfix shows for thexsandsmbreakpoints.