Account for badges in buttons #11268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -49,3 +50,33 @@ a.list-group-item.active > .badge, | |||
| .nav-pills > li > a > .badge { | |||
| margin-left: 3px; | |||
| } | |||
|
|
|||
| // Account for badges in buttons | |||
| .btn-primary .badge, | |||
There was a problem hiding this comment.
Use nesting so that .badge doesn't have to be repeated.
|
Thanks for the tip, I've updated the less to include nesting |
|
X-Ref: #11217 |
Closed
|
Fixed manually with an update to the button variant mixin. Thanks! |
mdo
added a commit
that referenced
this pull request
Dec 1, 2013
…d to text color and text color to background
|
There appears to be an issue with a badge on a btn btn-default where the badge background color is white and the color is also white. |
|
@etishor Please open a new bug. |
stempler
pushed a commit
to stempler/bootstrap
that referenced
this pull request
Apr 11, 2014
…g background to text color and text color to background
stempler
pushed a commit
to stempler/bootstrap
that referenced
this pull request
Nov 4, 2014
…g background to text color and text color to background
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion for making badges in buttons look better.
PS. No idea where the select came from, just did a "grunt dist"