Buttons Tests #1024
Merged
Buttons Tests #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tTimeout() function
|
hi @gnuwilliam setTimeout(function () {
state == 'loadingText' ?
$el.addClass(d).attr(d, d) :
$el.removeClass(d).removeAttr(d)
}, 0)
why not invoking directly without setTimeout? |
|
Yep, I would say the same. But this was already implemented, so I've decided to keep this way. If there is no problem changing it, I can do that and test it without the asynchronous way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I was taking a look in the unit tests, and some of them was failing (button stuff), then I noticed that some of them should be asynchronous tests, since it was using an asynchronous functionality, the setTimeout()
I've created asynchronous tests for them, and now all the tests are passing.
Thanks, see ya! :)