Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segmented buttons / input-group-btn border depending on font-size #11883

Closed
tlindig opened this issue Dec 15, 2013 · 8 comments
Closed

Segmented buttons / input-group-btn border depending on font-size #11883

tlindig opened this issue Dec 15, 2013 · 8 comments
Labels
Milestone

Comments

@tlindig
Copy link
Contributor

tlindig commented Dec 15, 2013

With base-font-size 17px, I get a gap and double border in segmented buttons.

Here the example: http://jsbin.com/UNopeHOY/6/edit?html,css,output

@mdo
Copy link
Member

mdo commented Dec 15, 2013

I doubt there will be any 100% foolproof way to support this—there are so many nuances to the button and input groups.

@tlindig
Copy link
Contributor Author

tlindig commented Dec 15, 2013

Would be fixed by: #11817

@mdo
Copy link
Member

mdo commented Dec 15, 2013

We used to have the font-size: 0; hack, but ran into issues of nested and custom content inheriting that. It require extra overrides to make it work.

@tlindig
Copy link
Contributor Author

tlindig commented Dec 15, 2013

What a custom content is in a input-group-btn?

@mdo
Copy link
Member

mdo commented Dec 15, 2013

@tlindig I'm not talking about v3 now—there's likely no problem there now. In v2.x we had issues though due to tooltip and popover placement. Custom content was the wrong term to use, also, so sorry for the confusion.

Either way, you are right, we need a better solution for this stuff. Looking into it now.

@tlindig
Copy link
Contributor Author

tlindig commented Dec 15, 2013

If font-size: 0 is not a possible solution, it would be more correct to say "do not use space character between elements in input-group-btn". But try to move over a space character, looks dirty IMHO.

@mdo
Copy link
Member

mdo commented Dec 15, 2013

Revisited and merged #11817. Thanks for hammering this home @tlindig—definitely an oversight on my part. Appreciate the attention to detail <3.

@mdo mdo closed this as completed Dec 15, 2013
@tlindig
Copy link
Contributor Author

tlindig commented Dec 15, 2013

Wow, I am impressed. Respect!

Sorry, if I use to harsh words and that I spammed a little.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants