-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segmented buttons double border #11431
Comments
It isn't about margins and I don't love fixing a look of things with margins. X-Ref (I'm working on fix for your issue): #11407 |
Uhm, that's okay with me but why can't we use margins to solve this? Using |
Your problem is fixed in #11435. |
Fixed by #11435. |
This pull request #11435 you accepted is hacking. It dose two things.
That has nothing to do with this problem. But it make the css more complex.
Makes the css also more complex and is hacking. It works fine for font-size 14px, but not more. You want know the reason? Read the comment in my pull request #11817. If you do not believe me, here is a example: http://jsbin.com/UNopeHOY/3/edit?html,css,output with |
Agree |
@tlindig About what hacking are you talking about? :O |
I think it's already been solved at #11817 |
With hacking I mean a programming technique "try and error". The goal is to suppress the symptoms. IMHO that kind of solution should be the last choice. The first choice should be the elimination of the cause, if it is possible. In this special case we have this situation: |
Hello,
(Even in the Bootstrap example), the segmented buttons (right of the input field) seem to have a double border between them.
I looked around a bit, and this can be fixed easily by applying
margin-right: -1px;
to the left button of the segmented buttons (which are right of the input field).It's a small detail, but it does look better.
The text was updated successfully, but these errors were encountered: