Add/Update monthly controls [Oct 23]. Closes #711 #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
misraved
reviewed
Oct 20, 2023
There was a problem hiding this comment.
@Priyanka-Chatterjee-2000 please take a look at the review comments. Thanks!!
| end status, | ||
| p.name || ' contains ' || coalesce(bad.statements_num,0) || | ||
| ' statements that allow action "*" on resource "*".' as reason | ||
| ${replace(local.common_dimensions_qualifier_global_sql, "__QUALIFIER__", "p.")} |
There was a problem hiding this comment.
Does the resource support tags? If yes, I think we should add the tag dimensions as well.
There was a problem hiding this comment.
For aws_iam_role and aws_iam_user they support tagging but aws_iam_group does not support tagging and in this query, we are doing a union of the three tables, that is the reason we cannot use tags here.
Co-authored-by: Ved misra <47312748+misraved@users.noreply.github.com>
madhushreeray30
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist