Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixlambda_runtime(sign): Update lambda runtimes to match current AWS guidelines #696

Merged
merged 6 commits into from
Jul 27, 2023

Conversation

papaharry
Copy link

Checklist

  • Issue(s) linked

Haven't created an issue yet, but happy to if it needs it for the check

@papaharry papaharry changed the title fixlambda_runtime(sign): Update lambda runtimes to much current AWS guidelines fixlambda_runtime(sign): Update lambda runtimes to match current AWS guidelines Jul 25, 2023
@rajlearner17 rajlearner17 changed the base branch from main to release/v0.77 July 25, 2023 14:29
Co-authored-by: Raj <raj@turbot.com>
Copy link
Contributor

@rajlearner17 rajlearner17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khushboo9024
Copy link
Contributor

Hi papaharry thanks for raising the PR. 👍

We noticed that the list of runtimes in the query does not match the runtimes specified in the FSBP document, which we strictly follow for all FSBP controls.

Could you kindly update the query to align with the specifications mentioned in the FSBP document? Alternatively, please provide the source document you referenced for this information.

image

Thanks.

@papaharry
Copy link
Author

Hello, I have added the missing runtime. I took the runtimes from the here but I missed that one.

@misraved misraved merged commit 8fa8de7 into turbot:release/v0.77 Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants