Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/Update AWS Audit Manager > NIST Cybersecurity Framework version 1.1 controls. Closes #623 #631

Merged
merged 9 commits into from
May 25, 2023

Conversation

Priyanka-Chatterjee-2000
Copy link
Contributor

Checklist

  • Issue(s) linked

@rajlearner17 rajlearner17 self-requested a review May 24, 2023 06:42
@Priyanka-Chatterjee-2000 Priyanka-Chatterjee-2000 changed the title Add/Update AWS Audit Manager > NIST Cybersecurity Framework version 1.1 controls Add/Update AWS Audit Manager > NIST Cybersecurity Framework version 1.1 controls. Closes #623 May 25, 2023
Copy link
Contributor

@madhushreeray30 madhushreeray30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly look at the comments. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Priyanka-Chatterjee-2000 cloudwatch_alarm_action_enabled_check is a duplicate control.

@@ -34,6 +34,18 @@ control "cloudwatch_alarm_action_enabled" {
})
}

control "cloudwatch_alarm_action_enabled_check" {
title = "CloudWatch alarm action should be enabled"
description = "Checks if Amazon CloudWatch alarms actions are in enabled state. The rule is non compliant if the CloudWatch alarms actions are not in enabled state."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = "Checks if Amazon CloudWatch alarms actions are in enabled state. The rule is non compliant if the CloudWatch alarms actions are not in enabled state."
description = "Checks if Amazon CloudWatch alarm actions are in enabled state. The rule is non compliant if the CloudWatch alarm actions are not in enabled state."

@madhushreeray30 madhushreeray30 self-requested a review May 25, 2023 11:56
@misraved misraved merged commit a493162 into release/v0.66 May 25, 2023
@misraved misraved deleted the issue#623 branch May 25, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add/Update AWS Audit Manager > NIST Cybersecurity Framework version 1.1 controls (2023-05-09)
3 participants