Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/Update AWS Audit Manager > NIST Cybersecurity Framework version 1.1 (2023-03-20). Closes #587 #604

Merged
merged 14 commits into from
Apr 20, 2023

Conversation

Priyanka-Chatterjee-2000
Copy link
Contributor

Checklist

  • Issue(s) linked

Base automatically changed from release/v0.62 to main April 13, 2023 13:04
@khushboo9024 khushboo9024 changed the base branch from main to release/v0.63 April 14, 2023 06:08
@rajlearner17 rajlearner17 removed their request for review April 14, 2023 06:08
Copy link
Contributor

@madhushreeray30 madhushreeray30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Priyanka-Chatterjee-2000 Can you please have a look at the comments! Thanks.

Comment on lines 70 to 72
audit_manager_pci_v321 = "true"
nist_csf = "true"
well_architected = "true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tags are wrong.

@@ -49,6 +52,8 @@ control "opensearch_domain_audit_logging_enabled" {

tags = merge(local.conformance_pack_opensearch_common_tags, {
gxp_21_cfr_part_11 = "true"
gxp_eu_annex_11 = "true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
gxp_eu_annex_11 = "true"

Comment on lines 82 to 85
gxp_21_cfr_part_11 = "true"
gxp_eu_annex_11 = "true"
hipaa_security_rule_2003 = "true"
nist_csf = "true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
gxp_21_cfr_part_11 = "true"
gxp_eu_annex_11 = "true"
hipaa_security_rule_2003 = "true"
nist_csf = "true"
gxp_21_cfr_part_11 = "true"
gxp_eu_annex_11 = "true"
hipaa_final_omnibus_security_rule_2013 = "true"
hipaa_security_rule_2003 = "true"
nist_csf = "true"

Comment on lines 95 to 96
hipaa_security_rule_2003 = "true"
nist_csf = "true"
Copy link
Contributor

@khushboo9024 khushboo9024 Apr 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hipaa_security_rule_2003 = "true"
nist_csf = "true"
hipaa_final_omnibus_security_rule_2013 = "true"
hipaa_security_rule_2003 = "true"
nist_csf = "true"

@@ -61,21 +66,23 @@ control "opensearch_domain_logs_to_cloudwatch" {

tags = merge(local.conformance_pack_opensearch_common_tags, {
gxp_21_cfr_part_11 = "true"
gxp_eu_annex_11 = "true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
gxp_eu_annex_11 = "true"

@@ -223,8 +225,10 @@ control "rds_db_instance_deletion_protection_enabled" {
ffiec = "true"
gxp_21_cfr_part_11 = "true"
hipaa_final_omnibus_security_rule_2013 = "true"
nist_800_171_rev_2 = "true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
nist_800_171_rev_2 = "true"

Comment on lines 105 to 106
gxp_21_cfr_part_11 = "true"
gxp_eu_annex_11 = "true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tags are wrong.

@@ -17,8 +17,10 @@ control "ec2_ebs_default_encryption_enabled" {
gxp_eu_annex_11 = "true"
hipaa_final_omnibus_security_rule_2013 = "true"
hipaa_security_rule_2003 = "true"
nist_800_171_rev_2 = "true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
nist_800_171_rev_2 = "true"

@misraved misraved changed the title Add/Update AWS Audit Manager > NIST Cybersecurity Framework version 1.1 (2023-03-20). Closes#587 Add/Update AWS Audit Manager > NIST Cybersecurity Framework version 1.1 (2023-03-20). Closes #587 Apr 20, 2023
Copy link
Contributor

@misraved misraved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the review comments. Thanks!!

conformance_pack/cloudwatch.sp Show resolved Hide resolved
conformance_pack/codebuild.sp Outdated Show resolved Hide resolved
conformance_pack/ec2.sp Show resolved Hide resolved
conformance_pack/elb.sp Outdated Show resolved Hide resolved
conformance_pack/elb.sp Outdated Show resolved Hide resolved
conformance_pack/iam.sp Show resolved Hide resolved
conformance_pack/lambda.sp Outdated Show resolved Hide resolved
conformance_pack/rds.sp Outdated Show resolved Hide resolved
conformance_pack/redshift.sp Outdated Show resolved Hide resolved
conformance_pack/s3.sp Show resolved Hide resolved
@misraved misraved merged commit bc707d1 into release/v0.63 Apr 20, 2023
@misraved misraved deleted the issue-587 branch April 20, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add/Update AWS Audit Manager > NIST Cybersecurity Framework version 1.1 (2023-03-20)
4 participants