-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweaks #74
Tweaks #74
Conversation
If you have an ES6+ ESLint config, we should switch to that to ensure everything is compliant in the future. Not a stopper, but would be nice to have. |
Thanks a lot @XhmikosR! I'll give you rights to maintain this package if you are interested. I'd be glad to pass off responsibility for it (as I'm not an active grunt user). |
Haha, me neither :) I just still use it in a few projects so I thought we'd tweak this. You can add me, no problem, I just can't make any promises I'll keep contributing for a long time :) |
@tschaub: Here's the things I'd like to fix soon-ish for the next release
|
I think working on #76 would provide the most benefit (remove the most code). But feel free to prioritize as you see fit – I won't have any real time to work on this. Regarding the ESLint config, the current config is set up for ES2018. |
Hmm, it seems the config isn't enforcing all ES6 features like no var, prefer arrow, template literals etc. Not a big deal, just wanted to make this consistent in the future. And yeah, I agree, since you have that package, that should be the first priority and should fix of the issues I mentioned. If not we can sort them upstream and every package will benefit. |
@tschaub: sorry for not splitting this, I could try splitting it if you want later.
Now, this fixes tests on Windows with autocrlf enabled, updates all the stuff and fixes a DeprecationWarning with node >= 8 when running the tests.
The only thing left is to replace grunt-cafe with something else.Do let me know if you want me to change something and I can rebase this as needed :)