Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable trivy fs-vuln #503

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Conversation

puzzler7
Copy link
Contributor

@puzzler7 puzzler7 commented Oct 4, 2023

Trivy fs-vuln and osv-scanner report duplicate issues - after discussion here, we've decided to disable trivy fs-vuln for now and potentially handle duplicate issues more robustly down the line.

@trunk-io
Copy link

trunk-io bot commented Oct 4, 2023

⏱️ 37m total CI duration on this PR
Job Cumulative Duration Recent Runs
Linter Tests (macos-latest) 13m 🟩🟩
Windows Linter Tests 10m 🟩🟩
Linter Tests (ubuntu-latest) 7m 🟩🟩
CodeQL-Build 5m 🟩🟩
Repo Tests / Plugin Tests 2m 🟩🟩
Detect changed files 27s 🟩🟩
Aggregate Test Results 2s 🟩🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Collaborator

@TylerJang27 TylerJang27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please also add a README.md next to trivy with instructions to enable the other ones, see pre-commit-hooks

@TylerJang27 TylerJang27 merged commit 1146a6e into main Oct 5, 2023
@TylerJang27 TylerJang27 deleted the maverick/disable-trivy-fs-vuln branch October 5, 2023 06:38
pat-trunk-io pushed a commit that referenced this pull request Jan 22, 2024
Trivy fs-vuln and osv-scanner report duplicate issues - after discussion
[here](https://docs.google.com/document/d/1uS4CUtlM3MnvzTxn2iRGF9GMagVAIcVbDqKdQaDJOl4/edit),
we've decided to disable trivy fs-vuln for now and potentially handle
duplicate issues more robustly down the line.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants