Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New line linter #502

Merged
merged 6 commits into from
Oct 4, 2023
Merged

New line linter #502

merged 6 commits into from
Oct 4, 2023

Conversation

pat-trunk-io
Copy link
Contributor

@pat-trunk-io pat-trunk-io commented Oct 4, 2023 •
edited
Loading

Enables with:

enabled:
    - pre-commit-hooks@4.4.0:
        commands:
        - end-of-file-fixer

@trunk-io
Copy link

trunk-io bot commented Oct 4, 2023 •
edited
Loading

⏱️ 1h 13m total CI duration on this PR
Job Cumulative Duration Recent Runs
Linter Tests (macos-latest) 26m ⬜ 🟥 ⬜ ⬜ 🟩 
Linter Tests (ubuntu-latest) 22m ⬜ 🟥 ⬜ 🟩 🟩 
Windows Linter Tests 12m 🟩 🟩 ⬜ ⬜ 🟩 
CodeQL-Build 9m 🟩 🟩 🟩 🟩 🟩 
Repo Tests / Plugin Tests 4m 🟥 🟩 🟩 🟩 🟩 
Detect changed files 40s 🟩 🟩 🟩 🟩 🟩 
Aggregate Test Results 13s 🟥 🟥 🟥 🟥 🟩 

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

TylerJang27
TylerJang27 approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@TylerJang27 TylerJang27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with a couple changes. Please also add a README.md in this linter folder with setup instructions for enabling individual commands, etc.

linters/pre-commit-hooks/plugin.yaml Show resolved Hide resolved
@pat-trunk-io pat-trunk-io enabled auto-merge (squash) October 4, 2023 21:05
@pat-trunk-io pat-trunk-io merged commit 6a633c3 into main Oct 4, 2023
@pat-trunk-io pat-trunk-io deleted the pat/newlineLinter branch October 4, 2023 21:10
pat-trunk-io added a commit that referenced this pull request Jan 22, 2024
@pat-trunk-io
New line linter (#502)
5d54cab 
Enables with:

```
enabled:
    - pre-commit-hooks@4.4.0:
        commands:
        - end-of-file-fixer
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerJang27 TylerJang27 TylerJang27 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pat-trunk-io @TylerJang27