Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jq definition to handle release label including jq- #485

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Update jq definition to handle release label including jq- #485

merged 2 commits into from
Sep 21, 2023

Conversation

EliSchleifer
Copy link
Member

JQ was not properly defined with semver parsing from GH release data. Fixed now. And removed the version check

@trunk-io
Copy link

trunk-io bot commented Sep 21, 2023 •
edited
Loading

⏱️ 16m total CI duration on this PR
Job Cumulative Duration Recent Runs
Windows Tool Tests 8m ⬜ 🟩 
CodeQL-Build 3m 🟩 🟩 
Tool Tests (macos-latest) 2m 🟥 🟩 
Tool Tests (ubuntu-latest) 2m 🟥 🟩 
Repo Tests / Plugin Tests 1m 🟥 🟩 
Detect changed files 10s 🟩 🟩 
Aggregate Test Results 4s 🟥 🟩 

🚨 3 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
Windows Tool Tests 5m 3m +72%
Tool Tests (macos-latest) 1m 11m -87%
Tool Tests (ubuntu-latest) 1m 10m -89%

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

TylerJang27
TylerJang27 approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@TylerJang27 TylerJang27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might run into some issues like iwyu if we build out more infra for the testing here, but this looks good for current setup

@EliSchleifer EliSchleifer merged commit 5832920 into main Sep 21, 2023
@EliSchleifer EliSchleifer deleted the eli/jq-support branch September 21, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerJang27 TylerJang27 TylerJang27 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EliSchleifer @TylerJang27