Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python docstrings from ruff default rules #483

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

TylerJang27
Copy link
Collaborator

@TylerJang27 TylerJang27 commented Sep 19, 2023

Ruff's primary offering is more than just docstrings, and this can be really noisy on init. Let's remove it and users can always add it back in. This will effect users on init and trunk check enable ruff and the default config we dump. See trunk-io/configs#30

@trunk-io
Copy link

trunk-io bot commented Sep 19, 2023

⏱️ 12m total CI duration on this PR
Job Total Duration Recent Runs
Linter Tests (macos-latest) 5m 🟩
Windows Linter Tests 2m 🟩
Linter Tests (ubuntu-latest) 2m 🟩
CodeQL-Build 2m 🟩
Repo Tests / Plugin Tests 38s 🟩
Detect changed files 5s 🟩
Aggregate Test Results 3s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@TylerJang27 TylerJang27 requested review from det and dapirian September 19, 2023 23:15
TylerJang27 added a commit to trunk-io/configs that referenced this pull request Sep 20, 2023
@TylerJang27 TylerJang27 marked this pull request as ready for review September 21, 2023 17:22
Copy link
Member

@EliSchleifer EliSchleifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TylerJang27 TylerJang27 merged commit de0dae0 into main Sep 25, 2023
@TylerJang27 TylerJang27 deleted the tyler/ruff-rules branch September 25, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants