Ripgrep integration + rust runtime fixes #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
laurit17
commented
Aug 15, 2023
laurit17
commented
- make the trunk tools generate template a little bit smarter
- bump the rust runtime version so it supports ripgrep
- integrate ripgrep (39.4K stars)
- fix environment spec for rust runtime
TylerJang27
reviewed
Aug 15, 2023
| @@ -13,7 +13,4 @@ lint: | |||
| stdin: true | |||
| formatter: true | |||
| suggest_if: files_present | |||
| environment: | |||
| - name: PATH | |||
| list: ["${linter}/bin"] | |||
There was a problem hiding this comment.
I think we can also apply this to clippy and rustfmt, correct?
There was a problem hiding this comment.
ah - these are different because they are rust downloads. we can convert to runtime shims. will do so separately.
TylerJang27
approved these changes
Aug 15, 2023
TylerJang27
added a commit
that referenced
this pull request
Nov 29, 2023
- Eslint: new `tools.runtimes` functionality requires explicitly specifying runtime shims - nixpkgs-fmt: transitive dependencies were no longer compatible with the pinned runtime version. Bumped to KGV, see #436 - Adds additional debug logs since eslint has been failing more frequently lately This should fix the cross-repo tests since the new CLI versions will require these changes. **These tests will not pass until we get a new staging release with Windows shim fixes. Will bump version and land after that's out.**
pat-trunk-io
pushed a commit
that referenced
this pull request
Jan 22, 2024
- Eslint: new `tools.runtimes` functionality requires explicitly specifying runtime shims - nixpkgs-fmt: transitive dependencies were no longer compatible with the pinned runtime version. Bumped to KGV, see #436 - Adds additional debug logs since eslint has been failing more frequently lately This should fix the cross-repo tests since the new CLI versions will require these changes. **These tests will not pass until we get a new staging release with Windows shim fixes. Will bump version and land after that's out.**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.