Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump workflow timeouts #422

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Bump workflow timeouts #422

merged 1 commit into from
Aug 8, 2023

Conversation

TylerJang27
Copy link
Collaborator

@TylerJang27 TylerJang27 commented Aug 7, 2023 •
edited
Loading

  • Bump nightly timeouts to 120 (timeout here and here). This is likely an overestimate, but the test times could inflate soon due to additional tools
  • Preemptively bump PR and repo test timeouts as well. This isn't a problem yet, and will only be a problem in the worst case in the future as more tool tests are added

It may soon be time for investigating faster runners or better impacted target detection to reduce PR test times.

@TylerJang27 TylerJang27 marked this pull request as ready for review August 7, 2023 17:48
@TylerJang27 TylerJang27 merged commit 7d5d1ce into main Aug 8, 2023
@TylerJang27 TylerJang27 deleted the tyler/bump-nightly-timeouts branch August 8, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@det det det approved these changes

@laurit17 laurit17 Awaiting requested review from laurit17

@pat-trunk-io pat-trunk-io Awaiting requested review from pat-trunk-io

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TylerJang27 @det