Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a tool-test-helper action #420

Merged
merged 3 commits into from
Aug 3, 2023
Merged

Create a tool-test-helper action #420

merged 3 commits into from
Aug 3, 2023
+135 −2

Conversation

laurit17
Copy link
Contributor

@laurit17 laurit17 commented Aug 3, 2023

Analogous to the linter one

@laurit17 laurit17 requested a review from TylerJang27 August 3, 2023 03:12
TylerJang27
TylerJang27 reviewed Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@TylerJang27 TylerJang27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See notes. Want to give a final copy pass after and then ready to stamp

.trunk/trunk.yaml Show resolved Hide resolved
repo-tools/tool-test-helper/generate Show resolved Hide resolved
repo-tools/tool-test-helper/generate Show resolved Hide resolved
repo-tools/tool-test-helper/generate Outdated Show resolved Hide resolved
repo-tools/tool-test-helper/generate Outdated Show resolved Hide resolved
@laurit17 laurit17 requested a review from TylerJang27 August 3, 2023 17:00
TylerJang27
TylerJang27 approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@TylerJang27 TylerJang27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laurit17 laurit17 merged commit c5998f8 into main Aug 3, 2023
@laurit17 laurit17 deleted the lauri/tool-dir-action branch August 3, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerJang27 TylerJang27 TylerJang27 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurit17 @TylerJang27