This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix: eth_subscribe logs
#2268
Merged
fix: eth_subscribe logs
#2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmurdoch
suggested changes
Feb 2, 2022
davidmurdoch
approved these changes
Feb 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, logs returned via
eth_subscribe("logs")returned all logs in an array. Geth's logging and Ganache v6 emit separately for each event. This change makes it so we emit separately for each log once again.Also, I've added some tests for filtering
eth_subscribe("logs")events.