Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] - add binutils dep to dockerfile #2061

Merged
merged 3 commits into from
Oct 31, 2023
Merged

[chore] - add binutils dep to dockerfile #2061

merged 3 commits into from
Oct 31, 2023

Conversation

ahrav
Copy link
Collaborator

@ahrav ahrav commented Oct 30, 2023

Description:

This allows us to correctly extract some archive file types on unix-like systems.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@ahrav ahrav requested a review from a team as a code owner October 30, 2023 19:43
@rgmz
Copy link
Contributor

rgmz commented Oct 30, 2023

Is it possible to warn or fail if these dependencies aren't present? I didn't have rpm2cpio installed on my machine and didn't realize this was an issue until I increased the log verbosity.

@ahrav
Copy link
Collaborator Author

ahrav commented Oct 30, 2023

Is it possible to warn or fail if these dependencies aren't present? I didn't have rpm2cpio installed on my machine and didn't realize this was an issue until I increased the log verbosity.

I thought we did return an error here. Wondering if it's worth setting this up in a way such that if a user doesn't want to install those deps, we still scan everything else? Or do we want to make it a required dep?

@rgmz
Copy link
Contributor

rgmz commented Oct 31, 2023 •
edited
Loading

thought we did return an error here.

It's possible, but I swear I've never seen that error. Or, at least, not without manually tweaking the logging levels and adding my own logging statements while troubleshooting an issue.

@ahrav ahrav merged commit 89b6315 into main Oct 31, 2023
8 checks passed
@ahrav ahrav deleted the chore-add-bintuils-to-docker-image branch October 31, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustin-decker dustin-decker dustin-decker approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahrav @rgmz @dustin-decker