Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skipping result: invalid (empty raw) #3717

Open
rgmz opened this issue Dec 2, 2024 · 1 comment
Open

Skipping result: invalid (empty raw) #3717

rgmz opened this issue Dec 2, 2024 · 1 comment
Labels
bug

Comments

@rgmz
Copy link
Contributor

rgmz commented Dec 2, 2024

Logs

2024-12-02T15:13:30-05:00	error	trufflehog	Skipping result: invalid	{"detector_worker_id": "Nk5FB", "detector": {"type":"GCPApplicationDefaultCredentials"}, "timeout": 60, "link": "https://github.com/Samsung/CredSweeper/blob/05e354ca3a245bcd411d2f4d09656e553fdba2c4/tests/data/output.json#L390", "error": "empty raw"}
2024-12-02T15:13:31-05:00	error	trufflehog	Skipping result: invalid	{"detector_worker_id": "Nk5FB", "detector": {"type":"GCPApplicationDefaultCredentials"}, "timeout": 60, "link": "https://github.com/Samsung/CredSweeper/blob/05e354ca3a245bcd411d2f4d09656e553fdba2c4/tests/data/output.json#L390", "error": "empty raw"}
2024-12-02T15:13:32-05:00	error	trufflehog	Skipping result: invalid	{"detector_worker_id": "DgH2D", "detector": {"type":"GCPApplicationDefaultCredentials"}, "timeout": 60, "link": "https://github.com/Samsung/CredSweeper/blob/05e354ca3a245bcd411d2f4d09656e553fdba2c4/tests/data/output.json#L390", "error": "empty raw"}
2024-12-02T15:13:34-05:00	error	trufflehog	Skipping result: invalid	{"detector_worker_id": "DgH2D", "detector": {"type":"GCPApplicationDefaultCredentials"}, "timeout": 60, "link": "https://github.com/Samsung/CredSweeper/blob/0243e0d00234cad7f8d3cddaba36200f5cfaa07d/tests/data/doc.json#L246", "error": "empty raw"}
2024-12-02T15:13:34-05:00	error	trufflehog	Skipping result: invalid	{"detector_worker_id": "pcjmR", "detector": {"type":"GCPApplicationDefaultCredentials"}, "timeout": 60, "link": "https://github.com/Samsung/CredSweeper/blob/0243e0d00234cad7f8d3cddaba36200f5cfaa07d/tests/data/doc.json#L246", "error": "empty raw"}
2024-12-02T15:13:37-05:00	error	trufflehog	Skipping result: invalid	{"detector_worker_id": "Mh0Lu", "detector": {"type":"GCPApplicationDefaultCredentials"}, "timeout": 60, "link": "https://github.com/Samsung/CredSweeper/blob/e37c3b2755ed59fe2e6c4eb52f9b012891d62060/tests/data/doc.json#L246", "error": "empty raw"}
2024-12-02T15:13:37-05:00	error	trufflehog	Skipping result: invalid	{"detector_worker_id": "cwDgF", "detector": {"type":"GCPApplicationDefaultCredentials"}, "timeout": 60, "link": "https://github.com/Samsung/CredSweeper/blob/e37c3b2755ed59fe2e6c4eb52f9b012891d62060/tests/data/doc.json#L246", "error": "empty raw"}
2024-12-02T15:13:40-05:00	error	trufflehog	Skipping result: invalid	{"detector_worker_id": "cwDgF", "detector": {"type":"GCPApplicationDefaultCredentials"}, "timeout": 60, "link": "https://github.com/Samsung/CredSweeper/blob/bc8aa7cc681321d9ab6ef510d06418246f2d51c8/tests/data/doc.json#L246", "error": "empty raw"}
2024-12-02T15:13:40-05:00	error	trufflehog	Skipping result: invalid	{"detector_worker_id": "Mh0Lu", "detector": {"type":"GCPApplicationDefaultCredentials"}, "timeout": 60, "link": "https://github.com/Samsung/CredSweeper/blob/bc8aa7cc681321d9ab6ef510d06418246f2d51c8/tests/data/doc.json#L246", "error": "empty raw"}
2024-12-02T15:14:01-05:00	error	trufflehog	Skipping result: invalid	{"detector_worker_id": "RCb9n", "detector": {"type":"GCPApplicationDefaultCredentials"}, "timeout": 60, "link": "https://github.com/Samsung/CredSweeper/blob/d5eade0666b8c1dd3acf8c2642d84925924d599a/tests/data/doc.json#L246", "error": "empty raw"}
2024-12-02T15:14:01-05:00	error	trufflehog	Skipping result: invalid	{"detector_worker_id": "RCb9n", "detector": {"type":"GCPApplicationDefaultCredentials"}, "timeout": 60, "link": "https://github.com/Samsung/CredSweeper/blob/d5eade0666b8c1dd3acf8c2642d84925924d599a/tests/data/doc.json#L246", "error": "empty raw"}
2024-12-02T15:14:04-05:00	error	trufflehog	Skipping result: invalid	{"detector_worker_id": "cwDgF", "detector": {"type":"GCPApplicationDefaultCredentials"}, "timeout": 60, "link": "https://github.com/Samsung/CredSweeper/blob/ed66340c7fdaac04f3aae43b914494e9aa1ea1a1/tests/data/doc.json#L246", "error": "empty raw"}
2024-12-02T15:14:04-05:00	error	trufflehog	Skipping result: invalid	{"detector_worker_id": "GQAPe", "detector": {"type":"GCPApplicationDefaultCredentials"}, "timeout": 60, "link": "https://github.com/Samsung/CredSweeper/blob/ed66340c7fdaac04f3aae43b914494e9aa1ea1a1/tests/data/doc.json#L246", "error": "empty raw"}
2024-12-02T15:14:07-05:00	error	trufflehog	Skipping result: invalid	{"detector_worker_id": "lAjcI", "detector": {"type":"GCPApplicationDefaultCredentials"}, "timeout": 60, "link": "https://github.com/Samsung/CredSweeper/blob/d825e312952022a5be2e871779374ec2817ab4e3/tests/data/doc.json#L246", "error": "empty raw"}
2024-12-02T15:14:07-05:00	error	trufflehog	Skipping result: invalid	{"detector_worker_id": "pcjmR", "detector": {"type":"GCPApplicationDefaultCredentials"}, "timeout": 60, "link": "https://github.com/Samsung/CredSweeper/blob/d825e312952022a5be2e871779374ec2817ab4e3/tests/data/doc.json#L246", "error": "empty raw"}

It appears that the gcpapplicationdefaultcredentials detector does not validate that the result is a non-empty string.

trufflehog/pkg/detectors/gcpapplicationdefaultcredentials/gcpapplicationdefaultcredentials.go

Lines 78 to 80 in c033f22

s1 := detectors.Result{
DetectorType: detectorspb.DetectorType_GCPApplicationDefaultCredentials,
Raw: []byte(detectedClientID),

Related: #3530
@rgmz rgmz added the bug label Dec 2, 2024
@kashifkhan0771
Copy link
Contributor

As per code the clientID is not being used anywhere else. What should be done if it's empty?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rgmz @kashifkhan0771