Accept caller-provided DynamoDB resources and clients #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
troylar
reviewed
Apr 24, 2017
|
That makes sense, though I haven't dug in deep on the code as of yet. |
|
doesn't matter to me where |
|
Since the DynamoDbDriver already has access to the client object, it would
save having to pass it as an extra parameter.
…On Mon, Apr 24, 2017 at 3:59 PM Corey Wright ***@***.***> wrote:
doesn't matter to me where does_table_exist() reside (though that will
reduce the size of the change), but moving it will not address the larger
problem (as i see it): allowing the caller to programmatically communicate
which dynamodb instance to use, instead of relying on the default session
with its environment variables, configuration file, and shared state (ie in
a large application different boto3 resources and client might need
different "defaults").
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB151BoYHv7QD-_zW9O2A23qGShZgHbwks5rzP8pgaJpZM4NGm1E>
.
|
Caller can provide a DynamoDB client instead of callee creating one using the default session (or requiring the caller to setup the default session).
Just as RedisProgressManager can be initialized with a RedisConnection, allow DynamoDbDriver to be initialized with a DynamoDbResource, instead of relying on the DynamoDB resource created by the boto3 default session (or requiring the caller to manipulate it beforehand). Use the corresponding DynamoDB client to test if the necessary DynanmoDB tables exist.
coreywright
force-pushed
the
dynamodb_programmatically
branch
from
6d70faf to
3fb6c00
Compare
|
rebased against master to eliminate merge conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of strictly creating DynamoDB resources and clients using
the default session, allow callers to provide one (instead of
requiring the caller to manipulate the default session).