Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/refactor runtime #1632

Merged
merged 5 commits into from
Oct 25, 2018
Merged

Feature/refactor runtime #1632

merged 5 commits into from
Oct 25, 2018

Conversation

huzhenyuan
Copy link
Contributor

What does this PR do?

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@codecov-io
Copy link

Codecov Report

Merging #1632 into develop will decrease coverage by 0.11%.
The diff coverage is 54.34%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1632      +/-   ##
=============================================
- Coverage      43.98%   43.87%   -0.12%     
+ Complexity      3221     3209      -12     
=============================================
  Files            415      415              
  Lines          23831    23835       +4     
  Branches        2426     2425       -1     
=============================================
- Hits           10483    10457      -26     
- Misses         12447    12475      +28     
- Partials         901      903       +2
Impacted Files Coverage Δ Complexity Δ
.../org/tron/core/capsule/TransactionInfoCapsule.java 23.52% <0%> (-0.24%) 12 <0> (ø)
src/main/java/org/tron/core/Wallet.java 23.06% <0%> (ø) 43 <0> (ø) ⬇️
src/main/java/org/tron/core/db/Manager.java 48.39% <31.25%> (+0.32%) 99 <2> (ø) ⬇️
...c/main/java/org/tron/core/db/TransactionTrace.java 49.61% <37.5%> (-0.79%) 15 <1> (ø)
...main/java/org/tron/common/runtime/RuntimeImpl.java 57.23% <57.23%> (ø) 34 <34> (?)
...ain/java/org/tron/core/capsule/ReceiptCapsule.java 50% <0%> (-20.32%) 12% <0%> (-5%)
...g/tron/core/net/message/ChainInventoryMessage.java 66.66% <0%> (-2.78%) 7% <0%> (-1%)
.../java/org/tron/core/net/node/NodeDelegateImpl.java 31.49% <0%> (-1.11%) 20% <0%> (-2%)
src/main/java/org/tron/core/net/node/NodeImpl.java 47.02% <0%> (-0.49%) 83% <0%> (-2%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5c7773...ad46e37. Read the comment docs.

@CodeNinjaEvan CodeNinjaEvan merged commit 63cc716 into develop Oct 25, 2018
@CodeNinjaEvan CodeNinjaEvan deleted the feature/refactor_runtime branch October 25, 2018 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeNinjaEvan CodeNinjaEvan CodeNinjaEvan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huzhenyuan @codecov-io @CodeNinjaEvan