Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Licence violations #64

Closed
TylerTheFox opened this issue Jan 16, 2018 · 9 comments
Closed

More Licence violations #64

TylerTheFox opened this issue Jan 16, 2018 · 9 comments

Comments

@TylerTheFox
Copy link

https://github.com/tronprotocol/java-tron/blob/develop/src/main/java/org/tron/crypto/cryptohash/Digest.java
https://github.com/ethereum/ethereumj/blob/165fe6060ca40325debcc3356b02c634f1f945ee/ethereumj-core/src/main/java/org/ethereum/crypto/cryptohash/Digest.java

Is missing this notice

  • ==========================(LICENSE BEGIN)============================
  • Copyright (c) 2007-2010 Projet RNRT SAPHIR
  • Permission is hereby granted, free of charge, to any person obtaining
  • a copy of this software and associated documentation files (the
  • "Software"), to deal in the Software without restriction, including
  • without limitation the rights to use, copy, modify, merge, publish,
  • distribute, sublicense, and/or sell copies of the Software, and to
  • permit persons to whom the Software is furnished to do so, subject to
  • the following conditions:
  • The above copyright notice and this permission notice shall be
  • included in all copies or substantial portions of the Software.
  • THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
  • EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
  • MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
  • IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
  • CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
  • TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
  • SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  • ===========================(LICENSE END)=============================
@ac-opensource
Copy link

ac-opensource commented Jan 16, 2018

Pull #65
Provided

@jromero
Copy link
Contributor

jromero commented Jan 16, 2018

Don't know what particular "license" that is but there is nothing about needing to retain attribution. It seems to be only a release of liability.

@TylerTheFox
Copy link
Author

Clearly states that this copyright notice "Copyright (c) 2007-2010 Projet RNRT SAPHIR" must be "included in all copies or substantial portions of the Software." Along with the permission notice.

The main thing being the copyright notice.

@njbrown09
Copy link

jesus christ what is wrong with this coin

@jromero
Copy link
Contributor

jromero commented Jan 16, 2018

@Brandantl You are right. I totally overlooked that one sentence. :) What are the odds...

@TylerTheFox
Copy link
Author

TylerTheFox commented Jan 17, 2018

Edit: This was a response to a user who deleted their message, not @jromero

Copyright extends to the life of the author + 75 years. So no lol. We'll all be dead before that copyright runs out.

Give credit where credit is due. Jeez, it's not that complex of a concept. Even if the copyright ran out it's still morally right to include it.

@daverose
Copy link

Its nice that people are reviewing the code, but how about you do a pull request with the changes you'd like implemented?

@joem789
Copy link

joem789 commented Jan 18, 2018

How bout stop trying to own intellectual information and let them do what they already know how to do?

zhaohong added a commit that referenced this issue Jan 19, 2018
add license
@zhaohong
Copy link
Contributor

zhaohong commented Jan 19, 2018

@Brandantl thanks for reviewing code.
@ac-opensource thanks for the pull provided.
I added the notice to the file
https://github.com/tronprotocol/java-tron/blob/develop/src/main/java/org/tron/common/crypto/cryptohash/Digest.java

zhaohong added a commit that referenced this issue Feb 5, 2018
add license
zergweak added a commit that referenced this issue Jun 18, 2018
@tronprotocol tronprotocol locked and limited conversation to collaborators Jun 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants
@jromero @daverose @zhaohong @TylerTheFox @ac-opensource @njbrown09 @joem789 and others