Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for 'None' on response data #443

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Add support for 'None' on response data #443

merged 1 commit into from
Jan 31, 2024

Conversation

avibhstarburst
Copy link
Contributor

@avibhstarburst avibhstarburst commented Jan 30, 2024 •
edited by hashhar
Loading

Description

Add support for 'None' on response data

Non-technical explanation

Release notes

( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text:

* Fix possible failures when retrieving query results if the server returns empty data. ({issue}`443`)

@cla-bot cla-bot bot added the cla-signed label Jan 30, 2024
hashhar
hashhar reviewed Jan 30, 2024
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hovaesco can you guide with how to add a unit test for this (using mocking since not easy to have isolated test case).

trino/client.py Outdated Show resolved Hide resolved
@hovaesco
Copy link
Member

To write a unit test here please create mock like

trino-python-client/tests/unit/conftest.py

Line 64 in ca38d29

def sample_get_response_data():
and then see how it's used in tests

trino-python-client/tests/unit/test_client.py

Line 682 in ca38d29

def test_trino_fetch_request(mock_requests, sample_get_response_data):

hashhar
hashhar reviewed Jan 31, 2024
View reviewed changes
tests/unit/conftest.py Outdated Show resolved Hide resolved
hashhar
hashhar approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comment.

hashhar
hashhar approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Will merge after CI is done.

@hashhar hashhar merged commit 191cd79 into trinodb:master Jan 31, 2024
12 checks passed
@hashhar hashhar mentioned this pull request Feb 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashhar hashhar hashhar approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avibhstarburst @hovaesco @hashhar