Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: comment not recognized inside binary expression #223

Closed
2 tasks done
calebdw opened this issue Feb 21, 2024 · 0 comments · Fixed by #224
Closed
2 tasks done

bug: comment not recognized inside binary expression #223

calebdw opened this issue Feb 21, 2024 · 0 comments · Fixed by #224
Labels

Comments

@calebdw
Copy link
Collaborator

calebdw commented Feb 21, 2024

Did you check existing issues?

  • I have read all the tree-sitter docs if it relates to using the parser
  • I have searched the existing issues of tree-sitter-php

Tree-Sitter CLI Version, if relevant (output of tree-sitter --version)

No response

Describe the bug

The fix introduced in 56f153e which adjusted the comment precedence incidentally broke comments inside other expressions (which there we no tests for).

Steps To Reproduce/Bad Parse Tree

n/a

Expected Behavior/Parse Tree

n/a

Repro

if (
  true
  // this is a comment
  || false
) {}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant