Simplify treatment of rules that are always aliased one way #197
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We're using the
alias
function a lot in several grammars, including tree-sitter-html. It's been really useful, but it has two downsides:alias_sequence_id
values.ERROR
nodes, because in that case, the aliases are not applied.The second problem came to my attention when adapting Atom's autocomplete-html package to work with Tree-sitter.
Solution
In this PR, I introduce an internal concept called simple aliases. A grammar symbol is considered to have a simple alias if the symbol is always used with that alias: it's never used without an alias, and it's never used with a different alias.
Simple aliases can be dealt with in a way that is, well, simpler than how we normally implement aliases 😁. This results in a smaller parse table. More importantly though, it causes the rule to always appear with the same name, even when it occurs inside of an
ERROR
, which makes the syntax tree more consistent and useful overall.