Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/devices api #990

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Fix/devices api #990

merged 2 commits into from
Nov 22, 2023

Conversation

nathanielsimard
Copy link
Member

Linked to #984

dcvz
dcvz approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@dcvz dcvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot more! It keeps the improvement but also doesn’t muddy the base API until you care about it.

@nathanielsimard nathanielsimard merged commit 630044e into main Nov 22, 2023
7 checks passed
@nathanielsimard nathanielsimard deleted the fix/devices-api branch November 22, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcvz dcvz dcvz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanielsimard @dcvz