Fix SQLite tests on Windows #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop the connection pool so that the database can be persisted. Fixes tracel-ai#946
The comment is outdated as it is possible to return a read-only and a read-write pool.
antimora
approved these changes
Nov 22, 2023
|
Thanks a lot @syl20bnr! Do you know by any chance how to proceed with #925 (comment) too? Because I'm a bit stucked and I cannot use a Windows machine |
I can take a look at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
run-checks allscript has been executed.Related Issues/PRs
Fixes #946
Changes
Drop the sqlite connection pool so that the database can be persisted on Windows.
Testing
No new code to test.
Ran all the tests on both Windows 11 and MacOS.