Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support count_include_pad attr in avg_pool2d ONNX #978

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Support count_include_pad attr in avg_pool2d ONNX #978

merged 1 commit into from
Nov 21, 2023

Conversation

antimora
Copy link
Collaborator

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

Fixes #636

Changes

  1. count_include_pad attribute is supported now in avg_pool2d ONNX. Previously PyTorch was exporting an extra padding node which they stopped doing in the new version of PyTorch.

Testing

  1. Updated ONNX file testing with new test cases.
  2. Ran checks.

nathanielsimard
nathanielsimard approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@nathanielsimard nathanielsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antimora antimora merged commit 445f41b into tracel-ai:main Nov 21, 2023
6 checks passed
Luni-4
Luni-4 reviewed Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@Luni-4 Luni-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for me too!

@nathanielsimard nathanielsimard deleted the count_include_pad branch November 22, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luni-4 Luni-4 Luni-4 left review comments

@nathanielsimard nathanielsimard nathanielsimard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for count_include_pad=False for AvgPool1d and AvgPool2d
3 participants
@antimora @Luni-4 @nathanielsimard