feature(tensor): Add unsqueeze_dim helper #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antimora
requested changes
Nov 19, 2023
There was a problem hiding this comment.
Looks good. A couple changes requested:
- Update the example with a preferred style.
- Update the Book tensor section with the new op: https://burn.dev/book/building-blocks/tensor.html#basic-operations
burn-tensor/src/tensor/api/base.rs
Outdated
| /// | ||
| /// fn example<B: Backend>() { | ||
| /// let tensor = Tensor::<B, 2>::ones(Shape::new([3, 3])); | ||
| /// let tensor = tensor.unsqueeze_dim::<3>(1); |
There was a problem hiding this comment.
Could we use this style instead?
let tensor:Tensor<B, 3> = tensor.unsqueeze_dim(1);<3> stands out compared to other Burn examples.
|
@antimora I think I've addressed all comments! |
antimora
approved these changes
Nov 19, 2023
nathanielsimard
approved these changes
Nov 20, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checksscript has been executed.Changes
Adds a
unsqueeze_dimmethod allowing you to target a specific dimension.Testing
I've added tests for the added method
Related Issue
fixes #876