Implement tensor.recip() function to calculate elementwise reciprocals #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzsombor
changed the title
|
Could we also please update the following documentation with the new tensor op? |
I updated both, I hope, this makes sense |
antimora
requested changes
Nov 13, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #953 +/- ##
==========================================
+ Coverage 87.34% 87.37% +0.03%
==========================================
Files 493 495 +2
Lines 50132 50269 +137
==========================================
+ Hits 43788 43923 +135
- Misses 6344 6346 +2 ☔ View full report in Codecov by Sentry. |
antimora
requested changes
Nov 14, 2023
There was a problem hiding this comment.
Overall looks good. One unit test is missing for autodiff.
@nathanielsimard would know more about the fusion part since it's new to me.
nathanielsimard
approved these changes
Nov 15, 2023
|
Welcome! And thank you for the quick reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checksscript has been executed.Related Issues/PRs
Provide links to relevant issues and dependent PRs.
Changes
There was no recip() method on the tensor, which is a common feature in other tensor libraries to calculate elementwise reciprocals.
Testing
Unit tests