ci/Fix cargo clippy action
#942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #942 +/- ##
==========================================
- Coverage 87.50% 87.42% -0.09%
==========================================
Files 502 502
Lines 51080 50967 -113
==========================================
- Hits 44697 44557 -140
- Misses 6383 6410 +27 ☔ View full report in Codecov by Sentry. |
Luni-4
force-pushed
the
remove-clippy
branch
3 times, most recently
from
92f8601 to
86ea54f
Compare
Luni-4
force-pushed
the
remove-clippy
branch
2 times, most recently
from
72c2f9a to
a073ebf
Compare
|
This PR is ready to be reviewd |
|
I rebased and CI is still failing. |
|
Yep, there are more clippy warnings to be fixed in the code |
Luni-4
force-pushed
the
remove-clippy
branch
from
82cc96f to
9e992d6
Compare
|
@antimora Rebased, but there are |
Luni-4
force-pushed
the
remove-clippy
branch
from
ac0b6e9 to
5e26da8
Compare
|
Every |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checksscript has been executed.Related Issues/PRs
Provide links to relevant issues and dependent PRs.
Changes
This PR fixes the
clippyaction removing the filtering based on diff that does not always allow to detect clippy warningsTesting
Describe how these changes have been tested.