Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the tests were flaky, and I suspect the problem came from unreliable initialization in
burn-wgpu
. The problem comes from the fact thatzeros
was achieved by multiplying an empty tensor by zero. However, the empty tensor might have invalid numbers in it, or NaN, which would make thezeros
orones
function return NaN as well. The fix is pretty simple: create aFull
kernel and use it to initialize tensors. This reduces the number of kernels launched and avoids uninitialized memory from causing numerical problems. I wasn't able to reproduce the flaky test after the change.